Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: vol exit update #220

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Feat: vol exit update #220

merged 2 commits into from
Sep 22, 2023

Conversation

rickimoore
Copy link
Member

sigp/lighthouse#4679

as mentioned the api endpoint for signing voluntary exit will change in response structure. This pr updates the signing function to accept data.data or data. Also contains unit test verifying both use cases

@rickimoore rickimoore mentioned this pull request Sep 21, 2023
Closed
michaelsproul
michaelsproul approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea supporting both for backwards-compatibility! 🔥

LGTM although this code is not super familiar to me.

I think we could merge and do some more testing before the release?

@rickimoore rickimoore merged commit 4be1e88 into unstable Sep 22, 2023
3 checks passed
@rickimoore rickimoore deleted the feat/vol-exit-update branch September 22, 2023 10:37
@rickimoore rickimoore mentioned this pull request Oct 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickimoore @michaelsproul